-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix calls of deprecated assert methods #23673
Merged
refack
merged 2 commits into
nodejs:master
from
prog1dev:test/remove_depricated_assert_equal_method
Nov 10, 2018
Merged
test: fix calls of deprecated assert methods #23673
refack
merged 2 commits into
nodejs:master
from
prog1dev:test/remove_depricated_assert_equal_method
Nov 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
Issues and PRs related to the tests.
tty
Issues and PRs related to the tty subsystem.
labels
Oct 15, 2018
prog1dev
force-pushed
the
test/remove_depricated_assert_equal_method
branch
from
October 15, 2018 18:04
35ab12b
to
b235d9f
Compare
prog1dev
changed the title
test: remove assert.equal from test-tty-get-color-depth.js test
test: remove calls of deprecated assert methods
Oct 15, 2018
prog1dev
force-pushed
the
test/remove_depricated_assert_equal_method
branch
from
October 15, 2018 18:15
b235d9f
to
1e137d1
Compare
prog1dev
force-pushed
the
test/remove_depricated_assert_equal_method
branch
from
October 28, 2018 14:24
1e137d1
to
76f0ba9
Compare
Could you guys review this please? |
I am only confident enough to humbly ping @nodejs/testing, @nodejs/assert and maybe @BridgeAR. |
BridgeAR
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with my comment addressed.
@vsemozhetbyt thanks for the ping. |
prog1dev
force-pushed
the
test/remove_depricated_assert_equal_method
branch
from
November 1, 2018 17:23
76f0ba9
to
9a71b82
Compare
Trott
reviewed
Nov 2, 2018
prog1dev
force-pushed
the
test/remove_depricated_assert_equal_method
branch
from
November 4, 2018 22:02
9a71b82
to
d2421b2
Compare
prog1dev
changed the title
test: remove calls of deprecated assert methods
test: fix calls of deprecated assert methods
Nov 4, 2018
ci build is green |
refack
approved these changes
Nov 10, 2018
PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
refack
force-pushed
the
test/remove_depricated_assert_equal_method
branch
from
November 10, 2018 16:47
d2421b2
to
53d424a
Compare
Landed in 04ccc98...53d424a 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 14, 2018
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Dec 14, 2018
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just went through assert docs and fixed calls of deprecated methods in tests:
assert.strictEqual
instead of deprecatedassert.equal
assert.fail([message])
instead of deprecatedassert.fail(actual, expected[, message[, operator[, stackStartFn]]])
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test