Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: add trace-events for time and count #23703

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 16, 2018

Add the node.console trace event category to capture
console.count(), console.countReset(), console.time(),
console.timeLog(), and console.timeEnd() to the trace
event log.

Fairly simple utility here. Pairs nicely with trace events for the perf_hooks API.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Oct 16, 2018
@jasnell jasnell added trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. console Issues and PRs related to the console subsystem. and removed console Issues and PRs related to the console subsystem. labels Oct 16, 2018
@jasnell
Copy link
Member Author

jasnell commented Oct 16, 2018

test/parallel/test-trace-events-console.js Outdated Show resolved Hide resolved
test/parallel/test-trace-events-console.js Outdated Show resolved Hide resolved
@jasnell
Copy link
Member Author

jasnell commented Oct 17, 2018

Add the `node.console` trace event category to capture
`console.count()`, `console.countReset()`, `console.time()`,
`console.timeLog()`, and `console.timeEnd()` to the trace
event log.
@jasnell
Copy link
Member Author

jasnell commented Oct 18, 2018

jasnell added a commit to jasnell/node that referenced this pull request Oct 18, 2018
Add the `node.console` trace event category to capture
`console.count()`, `console.countReset()`, `console.time()`,
`console.timeLog()`, and `console.timeEnd()` to the trace
event log.

PR-URL: nodejs#23703
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@jasnell
Copy link
Member Author

jasnell commented Oct 18, 2018

Landed in 9c82a1e

@addaleax
Copy link
Member

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

jasnell added a commit that referenced this pull request Oct 21, 2018
Add the `node.console` trace event category to capture
`console.count()`, `console.countReset()`, `console.time()`,
`console.timeLog()`, and `console.timeEnd()` to the trace
event log.

PR-URL: #23703
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
andrewhughes101 pushed a commit to andrewhughes101/node that referenced this pull request Mar 4, 2020
Add the `node.console` trace event category to capture
`console.count()`, `console.countReset()`, `console.time()`,
`console.timeLog()`, and `console.timeEnd()` to the trace
event log.

PR-URL: nodejs#23703
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Mar 9, 2020
Add the `node.console` trace event category to capture
`console.count()`, `console.countReset()`, `console.time()`,
`console.timeLog()`, and `console.timeEnd()` to the trace
event log.

PR-URL: #23703
Backport-PR-URL: #28840
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants