Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icu4c 63.1 #23715

Merged
merged 0 commits into from
Oct 24, 2018
Merged

Icu4c 63.1 #23715

merged 0 commits into from
Oct 24, 2018

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 17, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

The usual 63.1 bump:

  • icu 63.1 bump (CLDR 34) …
    • The following languages have been added to ICU: Sindhi, Maori, Turkmen, Javanese, Interlingua, Kurdish (ku), Xhosa, plus many data improvements.
    • Japanese new era testing support
  • Full release notes: http://site.icu-project.org/download/63

Fixes: #23244

  • Also, support URL failover for downloading ICU (full-icu mode). I added 2 extra URLs.
    Note shiny new github URL as primary!

@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Oct 17, 2018
@srl295 srl295 self-assigned this Oct 17, 2018
@srl295 srl295 requested a review from refack October 17, 2018 16:49
@nodejs-github-bot
Copy link
Collaborator

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1275/pipeline

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 17, 2018
This was referenced Oct 17, 2018
Closed
Closed
@srl295
Copy link
Member Author

srl295 commented Oct 19, 2018

confirmed that #22156 is fixed with this merge

@srl295 srl295 mentioned this pull request Oct 19, 2018
Merged
3 tasks
@srl295 srl295 requested a review from devsnek October 19, 2018 20:57
cclauss
cclauss reviewed Oct 21, 2018
View reviewed changes
tools/configure.d/nodedownload.py Outdated
@@ -38,6 +38,9 @@ def retrievefile(url, targetfile):
ConfigOpener().retrieve(url, targetfile, reporthook=reporthook)
print '' # clear the line
return targetfile
except IOError as err:
print ' ** IOError %s\n' % err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put from __future__ import print_function at the top of this file above other imports and then use the print() function instead of the print statement to be ready for Python 3. There are 437 days until Python 2 end of life.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss thanks, will do.

refack
refack approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes LGTM with nit fixed
ICU bump RSLGTM

cclauss
cclauss approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

richardlau
richardlau approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build files/tools changes LGTM.
RSLGTM ICU bump.

@srl295
Copy link
Member Author

srl295 commented Oct 23, 2018

https://ci.nodejs.org/job/node-test-pull-request/18058/ if i did it right

@srl295
Copy link
Member Author

srl295 commented Oct 23, 2018

should be semver minor

@richardlau richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 23, 2018
@srl295
Copy link
Member Author

srl295 commented Oct 24, 2018

restarted ci https://ci.nodejs.org/job/node-test-pull-request/18091/

@srl295
Copy link
Member Author

srl295 commented Oct 24, 2018

Ci now good

mhdawson
mhdawson approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@srl295 srl295 closed this Oct 24, 2018
srl295 added a commit to srl295/node that referenced this pull request Oct 24, 2018
@srl295
tools, icu: actually failover if there are multiple URLs
d8f2d27 
Building on nodejs#23269, if multiple ICU download URLs are present, try the
next one in case of error.

Part of the ICU 63.1 bump, but independent code-wise.
nodejs#23244

PR-URL: nodejs#23715
Fixes: nodejs#22344
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295 srl295 merged commit 6786ff4 into nodejs:master Oct 24, 2018
@cclauss
Copy link
Contributor

cclauss commented Oct 24, 2018

Awesome work here! Thanks.

@srl295 srl295 deleted the icu4c-63.1 branch October 24, 2018 16:57
targos pushed a commit that referenced this pull request Oct 26, 2018
@srl295 @targos
tools, icu: actually failover if there are multiple URLs
c20eb4f 
Building on #23269, if multiple ICU download URLs are present, try the
next one in case of error.

Part of the ICU 63.1 bump, but independent code-wise.
#23244

PR-URL: #23715
Fixes: #22344
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this pull request Oct 26, 2018
@srl295 @targos
deps: icu 63.1 bump (CLDR 34)
e5b51cc 
- Full release notes: http://site.icu-project.org/download/63

Fixes: #22344

PR-URL: #23715
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Oct 27, 2018
Merged
targos added a commit that referenced this pull request Oct 28, 2018
@targos
2018-10-30, Version 11.1.0 (Current)
3dfd630 
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922
hashseed pushed a commit to v8/node that referenced this pull request Oct 31, 2018
@srl295 @hashseed
deps: icu 63.1 bump (CLDR 34)
43a6704 
- Full release notes: http://site.icu-project.org/download/63

Fixes: nodejs#22344

PR-URL: nodejs#23715
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos added a commit that referenced this pull request Nov 1, 2018
@targos
2018-11-02, Version 11.1.0 (Current)
af6d262 
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922
targos added a commit that referenced this pull request Nov 2, 2018
@targos
2018-11-02, Version 11.1.0 (Current)
74ba482 
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
@richardlau richardlau mentioned this pull request Nov 5, 2018
Closed
rvagg added a commit to nodejs/changelog-maker that referenced this pull request Nov 9, 2018
@rvagg
minor nit
cc442b6 
Fake PR-URL for testing:

PR-URL: nodejs/node#23715
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@srl295 @BethGriggs
tools, icu: actually failover if there are multiple URLs
fc18e6f 
Building on #23269, if multiple ICU download URLs are present, try the
next one in case of error.

Part of the ICU 63.1 bump, but independent code-wise.
#23244

PR-URL: #23715
Fixes: #22344
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@srl295 @BethGriggs
deps: icu 63.1 bump (CLDR 34)
7a343db 
- Full release notes: http://site.icu-project.org/download/63

Fixes: #22344

PR-URL: #23715
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@srl295 @BethGriggs
tools, icu: actually failover if there are multiple URLs
2b9c492 
Building on #23269, if multiple ICU download URLs are present, try the
next one in case of error.

Part of the ICU 63.1 bump, but independent code-wise.
#23244

PR-URL: #23715
Fixes: #22344
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@srl295 @BethGriggs
deps: icu 63.1 bump (CLDR 34)
cd1939f 
- Full release notes: http://site.icu-project.org/download/63

Fixes: #22344

PR-URL: #23715
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@srl295 @MylesBorins
tools, icu: actually failover if there are multiple URLs
3ded3df 
Building on #23269, if multiple ICU download URLs are present, try the
next one in case of error.

Part of the ICU 63.1 bump, but independent code-wise.
#23244

PR-URL: #23715
Fixes: #22344
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@srl295 @MylesBorins
deps: icu 63.1 bump (CLDR 34)
e9a9c88 
- Full release notes: http://site.icu-project.org/download/63

Fixes: #22344

PR-URL: #23715
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs added a commit that referenced this pull request May 28, 2019
@BethGriggs
2019-05-28, Version 10.16.0 'Dubnium' (LTS)
9bc1d75 
Notable changes:

- deps:
  - icu 63.1 bump (CLDR 34) (Steven R. Loomis)
    [#23715](#23715)
  - upgrade npm to 6.9.0 (Kat Marchán)
    [#26244](#26244)
  - upgrade openssl sources to 1.1.1a (Sam Roberts)
    [#25381](#25381)
  - upgrade to libuv 1.24.1 (cjihrig)
    [#25078](#25078)
- events: add once method to use promises with EventEmitter
  (Matteo Collina) [#26078](#26078)
- n-api: mark thread-safe function as stable (Gabriel Schulhof)
  [#25556](#25556)
- repl: support top-level for-await-of (Shelley Vohr)
  [#23841](#23841)
- zlib:
  - add brotli support (Anna Henningsen)
  [#24938](#24938)

PR-URL: #27514
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
BaochengSu pushed a commit to BaochengSu/node that referenced this pull request Oct 20, 2020
@srl295 @BaochengSu
tools, icu: actually failover if there are multiple URLs
c1a860c 
Building on nodejs#23269, if multiple ICU download URLs are present, try the
next one in case of error.

Part of the ICU 63.1 bump, but independent code-wise.
nodejs#23244

PR-URL: nodejs#23715
Fixes: nodejs#22344
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
(cherry picked from commit d8f2d27)
renawolford6 added a commit to renawolford6/changelog-maker-javascript that referenced this pull request Nov 9, 2022
@renawolford6
minor nit
d7a9c2a 
Fake PR-URL for testing:

PR-URL: nodejs/node#23715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@cclauss cclauss cclauss approved these changes

@refack refack refack approved these changes

Assignees

@srl295 srl295

Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@srl295 @nodejs-github-bot @cclauss @refack @richardlau @devsnek @mhdawson