Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Do not merge #23741

Closed
wants to merge 2 commits into from
Closed

WIP: Do not merge #23741

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 18, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Trott added 2 commits October 17, 2018 19:18
@Trott
tools: do not lint commit message if var undefined
83628a4 
Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit
messages in Travis CI.

Refs: nodejs#23572 (comment)
Refs: nodejs#22842 (comment)
@Trott
fixup! tools: do not lint commit message if var undefined
c7be511
@Trott Trott added the wip Issues and PRs that are still a work in progress. label Oct 18, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1286/pipeline

@Trott Trott mentioned this pull request Oct 18, 2018
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Oct 18, 2018

YAML malformed. Escaping needed. Sticking with original escaping in #23725.

@Trott Trott closed this Oct 18, 2018
@Trott Trott deleted the travis-part-2 branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trott @nodejs-github-bot