Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document use of buffer.swap16() for utf16be #23747

Closed
wants to merge 5 commits into from
Closed

doc: document use of buffer.swap16() for utf16be #23747

wants to merge 5 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 19, 2018

Fixes: #12813

Checklist

@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1292/pipeline

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Oct 19, 2018
Trott
Trott reviewed Oct 19, 2018
View reviewed changes
doc/api/buffer.md Outdated
@@ -1936,6 +1936,14 @@ buf2.swap16();
// Throws ERR_INVALID_BUFFER_SIZE
```

One convenient use of `buf.swap16()` is to perform a fast *in-place* conversion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove italics?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it :)

lpinca
lpinca approved these changes Oct 19, 2018
View reviewed changes
doc/api/buffer.md Outdated Show resolved Hide resolved
vsemozhetbyt
vsemozhetbyt approved these changes Oct 19, 2018
View reviewed changes
doc/api/buffer.md Outdated Show resolved Hide resolved
doc/api/buffer.md Outdated Show resolved Hide resolved
vsemozhetbyt and others added 3 commits October 19, 2018 07:42
@vsemozhetbyt @jasnell
[Squash] nit
3e3c7cc 
Co-Authored-By: jasnell <jasnell@gmail.com>
@vsemozhetbyt @jasnell
[Squash] nit
f83ff61 
Co-Authored-By: jasnell <jasnell@gmail.com>
@lpinca @jasnell
[Squash] nit
d9d9c38 
Co-Authored-By: jasnell <jasnell@gmail.com>
jasnell
jasnell commented Oct 19, 2018
View reviewed changes
doc/api/buffer.md Outdated Show resolved Hide resolved
@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2018

Please 👍 to fast-track

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 19, 2018
jasnell added a commit that referenced this pull request Oct 19, 2018
@jasnell
doc: document use of buffer.swap16() for utf16be
ad61550 
Fixes: #12813

PR-URL: #23747
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2018

Landed in ad61550

@jasnell jasnell closed this Oct 19, 2018
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@jasnell @addaleax
doc: document use of buffer.swap16() for utf16be
c5ecc02 
Fixes: #12813

PR-URL: #23747
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell added a commit that referenced this pull request Oct 21, 2018
@jasnell
doc: document use of buffer.swap16() for utf16be
889a49f 
Fixes: #12813

PR-URL: #23747
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@jasnell @MylesBorins
doc: document use of buffer.swap16() for utf16be
f318d16 
Fixes: #12813

PR-URL: #23747
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: document use of buffer.swap16() for utf16be
f78d142 
Fixes: #12813

PR-URL: #23747
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jasnell @MylesBorins
doc: document use of buffer.swap16() for utf16be
aaf669d 
Fixes: #12813

PR-URL: #23747
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @Trott @lpinca @BridgeAR @vsemozhetbyt