Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing deprecation labels #23761

Closed
wants to merge 1 commit into from
Closed

doc: add missing deprecation labels #23761

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 19, 2018

Fixes: #20841

Checklist

@jasnell jasnell added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. deprecations Issues and PRs related to deprecations. labels Oct 19, 2018
@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1299/pipeline

@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2018

Please 👍 to fast-track

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2018
jasnell added a commit that referenced this pull request Oct 19, 2018
@jasnell
doc: add missing deprecation labels
814f89d 
Fixes: #20841

PR-URL: #23761
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2018

Landed in 814f89d

@jasnell jasnell closed this Oct 19, 2018
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@jasnell @addaleax
doc: add missing deprecation labels
261219b 
Fixes: #20841

PR-URL: #23761
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
jasnell added a commit that referenced this pull request Oct 21, 2018
@jasnell
doc: add missing deprecation labels
50c99d8 
Fixes: #20841

PR-URL: #23761
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@jasnell @MylesBorins
doc: add missing deprecation labels
4c9d993 
Fixes: #20841

PR-URL: #23761
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: add missing deprecation labels
ffbb423 
Fixes: #20841

PR-URL: #23761
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jasnell @MylesBorins
doc: add missing deprecation labels
4315899 
Fixes: #20841

PR-URL: #23761
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@mmarchini mmarchini mmarchini approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @codebytere @mmarchini @vsemozhetbyt