-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build,meta: bump gcc on travis #23778
Conversation
/CC @nodejs/build-files @nodejs/testing |
.travis.yml
Outdated
script: | ||
- make -j2 test | ||
- make test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refs: #23733
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d prefer to undo this unless it’s actually causing trouble on Travis – I don’t think we’ve seen this so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes the tests consistent with JEnkins, but I'll do it in another PR
.travis.yml
Outdated
script: | ||
- make -j2 test | ||
- make test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d prefer to undo this unless it’s actually causing trouble on Travis – I don’t think we’ve seen this so far.
.travis.yml
Outdated
- ./configure | ||
- make -j2 V= | ||
- CC='ccache gcc-4.9' && CXX='ccache g++-4.9' python configure.py --verbose | ||
- CC='ccache gcc-4.9' && CXX='ccache g++-4.9' make -j2 V= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe set these using export CC='ccache gcc-4.9' && CXX='ccache g++-4.9'
on the first line of install:
, and then leave these lines as they are?
Also, I’d prefer to keep ./configure
– firstly, the .travis.yml
of a project is sometimes used by devs to figure out how to build it, because it’s usually much more to-the-point than build instructions, and secondly that way we simply test more code than without it (namely the contents of configure
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm suspicious it's not behaving as we expect (hence it's using GCC over clang), so I'd rather has it explicit (like in Jenkins).
Ack on the ./configure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing export in install
From a quick google search, it seems like the error message is a clang one. |
So it might be just an |
@refack My guess is that it might be the gcc-provided libstdc++ 4.8 not playing along well with clang? Could be totally wrong on that one, though. (I also don’t remember the reason for picking clang in the first place, tbh.) |
I also changed the output generator from
to
(this is planned to change in Jenkins as well nodejs/build#1517) |
@refack One thing I’m noticing here is that the extra apt install took about a minute in https://travis-ci.com/nodejs/node/jobs/153110829 … not the end of the world, but something we might want to consider? |
.travis.yml
Outdated
- ./configure | ||
- make -j2 V= | ||
- make -j2 V=1 | sed -e "s/'.*\$//" -e "s|$PWD||g" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems nodejs/build#1517 is still being discussed. I'm not a fan of this change, can we revert it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
5310a62
to
aeae42a
Compare
But for some reason total was 13m While currently the jobs (using |
aeae42a
to
9e1081f
Compare
9e1081f
to
3c9fecb
Compare
It's back:
|
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: nodejs#23778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
a19546f
to
a2328da
Compare
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
The version of
clang
provided in the Travis linux image useslibstdc++4.8 whice is below our minimal supported version.
Switching to
make test -j1
is to avoid races during the test cyclecauses by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes