-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: refactor deprecated v8::String::NewFromTwoByte call #23803
Conversation
872378f
to
5e5684b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
src/node_process.cc
Outdated
@@ -52,7 +52,9 @@ using v8::HeapStatistics; | |||
using v8::Integer; | |||
using v8::Isolate; | |||
using v8::Local; | |||
using v8::MaybeLocal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I wouldn't add a using
just for 2 instances. In this case I would keep it explicit
@RomainLanz Thank you for the contribution, and all the follow ups 🥇 P.S. If you are having trouble doing that I could help. Also feel free to contact me if you need help in general. |
d1cadd1
to
08c1065
Compare
Done @refack 👍 |
Thanks! |
Landed in added1b 🎉 |
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes