doc: fix syntax in doc/api/path.md #23864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
reviewed
Oct 25, 2018
doc/api/path.md
Outdated
| @@ -20,7 +20,7 @@ paths are being used. | |||
|
|
|||
| For example, using the `path.basename()` function with the Windows file path | |||
| `C:\temp\myfile.html`, will yield different results when running on POSIX than | |||
| when run on Windows: | |||
| when running on Windows: | |||
There was a problem hiding this comment.
While we're in here, how about we take this opportunity to simplify the text? It's needlessly complex. It can probably be joined with the preceding paragraph too. How about just this?:
So using `path.basename()` might yield different results on POSIX and Windows:There was a problem hiding this comment.
Yeah, I'm willing to do this.
Trott
approved these changes
Oct 25, 2018
cjihrig
approved these changes
Oct 25, 2018
vsemozhetbyt
approved these changes
Oct 25, 2018
vsemozhetbyt
added
the
author ready
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
jasnell
approved these changes
Oct 25, 2018
|
Landed in 16673ae |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 25, 2018
PR-URL: nodejs#23864 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 26, 2018
PR-URL: #23864 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
PR-URL: #23864 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
PR-URL: #23864 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
PR-URL: #23864 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23864 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23864 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23864 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply fix typo in
doc/api/path.mdChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes