Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: make .destroy() interact better with write queue #24062

Closed
wants to merge 2 commits into from
Closed

stream: make .destroy() interact better with write queue #24062

wants to merge 2 commits into from

Commits on Nov 3, 2018

  1. stream: make .destroy() interact better with write queue 

    Make sure that it is safe to call the callback for `_write()`
even in the presence of `.destroy()` calls during that write.

In particular, letting the write queue continue processing would
previously have thrown an exception, because processing writes
after calling `.destroy()` is forbidden.

One test had to be modified to account for the fact that callbacks
for writes will now always be called, even when the stream
is destroyed during the process.
    @addaleax
    addaleax committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    af56ec2 View commit details
    Browse the repository at this point in the history

  2. fixup! stream: make .destroy() interact better with write queue

    @addaleax
    addaleax committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    589f159 View commit details
    Browse the repository at this point in the history