Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: respect assert.doesNotThrow message. #2407

Closed
wants to merge 4 commits into from
Closed

assert: respect assert.doesNotThrow message. #2407

wants to merge 4 commits into from

Commits on Apr 15, 2016

  1. assert: respect assert.doesNotThrow message. 

    Addresses nodejs#2385.
Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
    @diversario
    Ilya Shaisultanov authored and diversario committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    83ec4b5 View commit details
    Browse the repository at this point in the history

  2. assert: clean up conditional for _throws, fix docs. 

    Addresses nodejs#2407.
Break out conditional into named variables for readability.
Explain the purpose of `message` in throws/doesNotThrow assertions.
    @diversario
    diversario committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    d741140 View commit details
    Browse the repository at this point in the history

  3. assert: reformat docs, use const, refactor a test 

    Addresses nodejs#2407.
Wrap long lines in assert.markdown to be < 80 chars.
Use const instead of var in assert.js.
Refactor assert.doesNotThrow test to use assert.throws.
    @diversario
    diversario committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    f3eac76 View commit details
    Browse the repository at this point in the history

  4. assert: fix linter error in test-assert.js 

    Addresses nodejs#2407.
Wrap the line that exceeded 80 chars.
    @diversario
    diversario committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    610a38e View commit details
    Browse the repository at this point in the history