build: fix Travis non-PR builds #24093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't return non-zero if TRAVIS_PULL_REQUEST == "false".
2 tasks
refack
approved these changes
Nov 5, 2018
|
I'm not sure there's an easy way to test this in a non-PR scenario, other than maybe fudging (Edit: What I have done is run the command locally with |
|
Non PR travis: https://travis-ci.org/refack/node/builds/450653840 |
😁 |
|
Lite CI (since the last time I checked ncu doesn't recognise |
|
Please upvote to fast-track. |
refack
added
build
Trott
approved these changes
Nov 5, 2018
|
Landed in 809be43 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 5, 2018
Don't return non-zero if TRAVIS_PULL_REQUEST == "false". PR-URL: nodejs#24093 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Thanks everyone, and sorry for causing the original issue. |
targos
pushed a commit
that referenced
this pull request
Nov 5, 2018
Don't return non-zero if TRAVIS_PULL_REQUEST == "false". PR-URL: #24093 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
3 tasks
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Nov 29, 2018
Don't return non-zero if TRAVIS_PULL_REQUEST == "false". PR-URL: #24093 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Don't return non-zero if TRAVIS_PULL_REQUEST == "false". PR-URL: #24093 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 3, 2018
Don't return non-zero if TRAVIS_PULL_REQUEST == "false". PR-URL: #24093 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't return non-zero if
$TRAVIS_PULL_REQUEST== "false".Refs: #24076 (comment)
Checklist