Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 7.0.276.36 #24109

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 7.0.276.36 #24109

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 5, 2018

Refs: v8/v8@7.0.276.35...7.0.276.36

@nodejs/v8-update

@targos targos added v8 engine Issues and PRs related to the V8 dependency. dont-land-on-v6.x labels Nov 5, 2018
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1499/pipeline

@danbev
Copy link
Contributor

danbev commented Nov 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18361/

@targos
Copy link
Member Author

targos commented Nov 6, 2018

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1817/

@targos
Copy link
Member Author

targos commented Nov 9, 2018

Landed in 9d434db

@targos targos closed this Nov 9, 2018
@targos targos deleted the v8-36 branch November 9, 2018 11:11
targos added a commit to targos/node that referenced this pull request Nov 9, 2018
@targos
deps: patch V8 to 7.0.276.36
9d434db 
Refs: v8/v8@7.0.276.35...7.0.276.36

PR-URL: nodejs#24109
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@targos @BridgeAR
deps: patch V8 to 7.0.276.36
566399e 
Refs: v8/v8@7.0.276.35...7.0.276.36

PR-URL: #24109
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@targos @kiyomizumia
deps: patch V8 to 7.0.276.36
cebc2fd 
Refs: v8/v8@7.0.276.35...7.0.276.36

PR-URL: nodejs#24109
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@refack refack refack approved these changes

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @danbev @ofrobots @refack @cjihrig