Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: net eaddrinuse, change arguments order in strictEqual #24156

Closed
wants to merge 1 commit into from
Closed

test: net eaddrinuse, change arguments order in strictEqual #24156

wants to merge 1 commit into from

Conversation

Paul-Isache
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@trivikr
Copy link
Member

trivikr commented Nov 7, 2018

Hi @Paul-Isache, the author of this commit is not registered on Github (steps defined here)

Either:

  • add the email ID associated with the commit to Github
  • change the author of the commit to current email ID registered with the Github by following these steps

@Paul-Isache
Copy link
Contributor Author

Hi @trivikr,
I modified the author of the commit with the email that I am registered with.

@trivikr
Copy link
Member

trivikr commented Nov 7, 2018

Thanks @Paul-Isache, confirmed that it looks good!

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18439/

@gireeshpunathil
Copy link
Member

failures in arm and smart-os platforms seen yesterday, looks like some infra issues that got fixed.

resume CI: https://ci.nodejs.org/job/node-test-pull-request/18484/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 10, 2018
@Paul-Isache @Trott
test: change arguments order in strictEqual
a67e0a6 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: nodejs#24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 10, 2018

Landed in a67e0a6.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 10, 2018
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@Paul-Isache @BridgeAR
test: change arguments order in strictEqual
0c4facf 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: #24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@Paul-Isache @kiyomizumia
test: change arguments order in strictEqual
74ea574 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: nodejs#24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 13, 2018
@Paul-Isache @codebytere
test: change arguments order in strictEqual
b264d7e 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: #24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@Paul-Isache @MylesBorins
test: change arguments order in strictEqual
d7a3a3b 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: #24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Paul-Isache @trivikr @gireeshpunathil @Trott @cjihrig @BridgeAR @addaleax @codebytere @nodejs-github-bot