Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add typeerror for vm/compileFunction params #24179

Closed
wants to merge 2 commits into from
Closed

test: add typeerror for vm/compileFunction params #24179

wants to merge 2 commits into from

Conversation

dYale
Copy link
Contributor

@dYale dYale commented Nov 6, 2018

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@dYale dYale force-pushed the test-error-vm-compile-function-params branch from ba92b1e to a401f13 Compare November 6, 2018 16:37
@addaleax addaleax added vm Issues and PRs related to the vm subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 6, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18528/

@gireeshpunathil
Copy link
Member

linter error:

04:51:59 not ok 4 - /usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-vm-basic.js
04:51:59   ---
04:51:59   message: Expected indentation of 2 spaces but found 4.
04:51:59   severity: error
04:51:59   data:
04:51:59     line: 212
04:51:59     column: 1
04:51:59     ruleId: indent
04:51:59   messages:
04:51:59     - message: Expected indentation of 2 spaces but found 4.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 213
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 4 spaces but found 6.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 214
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 6 spaces but found 8.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 215
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 8 spaces but found 10.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 216
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 6 spaces but found 8.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 217
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 8 spaces but found 10.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 218
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 8 spaces but found 10.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 219
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 8 spaces but found 10.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 220
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Trailing spaces not allowed.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 220
04:51:59         column: 67
04:51:59         ruleId: no-trailing-spaces
04:51:59     - message: '''+'' should be placed at the end of the line.'
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 221
04:51:59         column: 12
04:51:59         ruleId: operator-linebreak
04:51:59     - message: Expected indentation of 6 spaces but found 8.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 222
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 4 spaces but found 6.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 223
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59     - message: Expected indentation of 2 spaces but found 4.
04:51:59       severity: error
04:51:59       data:
04:51:59         line: 224
04:51:59         column: 1
04:51:59         ruleId: indent
04:51:59   ...

the summary of the linter error message is that you need to de-indent all changes by 2 spaces, and move the + sign in line 221 to the previous line.

@gireeshpunathil
Copy link
Member

forgot to ping @dYale

@Trott
Copy link
Member

Trott commented Nov 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18615/

@Trott
Copy link
Member

Trott commented Nov 15, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18637/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 15, 2018
@dYale @Trott
test: add typeerror for vm/compileFunction params
3212f77 
PR-URL: nodejs#24179
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 15, 2018

Landed in 3212f77.

@Trott Trott closed this Nov 15, 2018
@BridgeAR BridgeAR mentioned this pull request Nov 15, 2018
Merged
BridgeAR pushed a commit that referenced this pull request Nov 15, 2018
@dYale @BridgeAR
test: add typeerror for vm/compileFunction params
eeb5cc6 
PR-URL: #24179
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@dYale @codebytere
test: add typeerror for vm/compileFunction params
585db59 
PR-URL: #24179
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
@beevelop beevelop mentioned this pull request Jan 29, 2019
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dYale @gireeshpunathil @Trott @jasnell @addaleax @joyeecheung @BridgeAR @nodejs-github-bot