Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: deleted unreachable code from util.inspect #24187

Closed
wants to merge 1 commit into from

Conversation

kiyomizumia
Copy link
Contributor

Contributed at NodeconfEU:

removed unreachable statement from util.inspect.

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 6, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Nov 6, 2018

Just having a glimpse at it but I believe the line was reachable?

@addaleax
Copy link
Member

addaleax commented Nov 6, 2018

@BridgeAR We did go through the code together, and it does not seem that way?

@addaleax
Copy link
Member

@BridgeAR Could you take another look?

CI: https://ci.nodejs.org/job/node-test-pull-request/18498/

@oyyd
Copy link
Contributor

oyyd commented Nov 12, 2018

@gireeshpunathil
Copy link
Member

Resume once again: https://ci.nodejs.org/job/node-test-commit/23173/

Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks unreachable to me, as this code seems to be run only for strings with length ≤ 100 that contain special chars.

@gireeshpunathil
Copy link
Member

landed as 531d854 , thanks!

gireeshpunathil pushed a commit that referenced this pull request Nov 13, 2018
PR-URL: #24187
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR
Copy link
Member

@ChALkeR you are correct. I forgot about the regular expression that makes sure that only strings reach that part that contain special characters. Thanks for pointing that out again.

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
PR-URL: #24187
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
PR-URL: nodejs#24187
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Jan 12, 2019
PR-URL: #24187
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants