Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update fs.open() changes record for optional 'flags' #24240

Closed
wants to merge 4 commits into from
Closed

doc: update fs.open() changes record for optional 'flags' #24240

wants to merge 4 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Nov 8, 2018

Was missed on original PR.

Ref: #23767

@nodejs-github-bot
Copy link
Collaborator

@rvagg build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1537/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Nov 8, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Nov 8, 2018
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@rvagg
Copy link
Member Author

rvagg commented Nov 9, 2018

hey @vsemozhetbyt & @cjihrig would you mind taking a look at the latest update here? I've given fs.openSync the same treatment and also copied the change doc for the as and as+ change that was introduced in #18801 but not documented in openSync.

@cjihrig
Copy link
Contributor

cjihrig commented Nov 9, 2018

@rvagg do the promises versions of these also need to be updated?

@rvagg
Copy link
Member Author

rvagg commented Nov 11, 2018

yeah, fsPromises.open got the same treatment, added a new commit with the change record there too

@vsemozhetbyt
Copy link
Contributor

@rvagg

yeah, fsPromises.open got the same treatment...

It seems the doc section for fsPromises.open() was not updated for this change. Maybe we can fix this in this PR?

-  * `flags` {string|number} See [support of file system `flags`][].
+  * `flags` {string|number} See [support of file system `flags`][]. **Default:** `'r'`.

@rvagg
Copy link
Member Author

rvagg commented Nov 12, 2018

Thanks @vsemozhetbyt, added that change to another fixup commit

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1583/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2018
@Trott
Copy link
Member

Trott commented Nov 12, 2018

Landed in 1532232

@Trott Trott closed this Nov 12, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 12, 2018
@rvagg @Trott
doc: update fs.open() changes record for optional 'flags'
1532232 
Was missed on original PR.

Ref: nodejs#23767

PR-URL: nodejs#24240
Refs: nodejs#23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg deleted the rvagg/fs.open_history branch November 12, 2018 07:28
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@rvagg @BridgeAR
doc: update fs.open() changes record for optional 'flags'
c68b0ae 
Was missed on original PR.

Ref: #23767

PR-URL: #24240
Refs: #23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@rvagg @kiyomizumia
doc: update fs.open() changes record for optional 'flags'
e850c06 
Was missed on original PR.

Ref: nodejs#23767

PR-URL: nodejs#24240
Refs: nodejs#23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
Closed
Closed
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@rvagg @codebytere
doc: update fs.open() changes record for optional 'flags'
6805908 
Was missed on original PR.

Ref: #23767

PR-URL: #24240
Refs: #23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@rvagg @MylesBorins
doc: update fs.open() changes record for optional 'flags'
b4c1d82 
Was missed on original PR.

Ref: #23767

PR-URL: #24240
Refs: #23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rvagg @nodejs-github-bot @vsemozhetbyt @cjihrig @Trott @jasnell