Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused context arg #24241

Closed
wants to merge 2 commits into from
Closed

Remove unused context arg #24241

wants to merge 2 commits into from

Commits on Nov 8, 2018

  1. test: simplify regression test for SEGV 

    Test was introduced in 08a5b44 as a regression test, and has evolved
since then. Simplify the test so that it doesn't rely on an undocumented
argument to tls.createSecureCredentials().

See: nodejs/node-v0.x-archive#6690

Confirmation that this reworked test triggers the original bug:

	%) % node
	> process.version
	'v0.10.48'
	> credentials = crypto.createCredentials()
	{ context: {} }
	> context = credentials.context
	{}
	> notcontext = { setOptions: context.setOptions }
	{ setOptions: [Function: setOptions] }
	> notcontext.setOptions()
	node: ../src/node_object_wrap.h:61: static T* node::ObjectWrap::Unwrap(v8::Handle<v8::Object>) [with T = node::crypto::SecureContext]: Assertion `handle->InternalFieldCount() > 0' failed.
	zsh: abort (core dumped)  node
    @sam-github
    sam-github committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    efb47cb View commit details
    Browse the repository at this point in the history

  2. tls: remove unused arg to createSecureContext() 

    The context arg is unused by node or its test suites and undocumented.
Remove it.
    @sam-github
    sam-github committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    ae8029d View commit details
    Browse the repository at this point in the history