-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: move encodeStr function to internal for reusable #24242
Conversation
Is the Benchmark CI result acceptable ? 🤔 BTW, didn't understand why we use function
instead of
|
The reason is that we allow users to override the |
I suppose so. |
@nodejs/url This doesn't technically need another review, but it would be nice. |
Landed in db9a745 |
PR-URL: nodejs#24242 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#24242 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
The encodeStr function and qsEscape function are almost the same.
Extract encodeStr function and move it to internal for reusable.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passescc @mscdex