Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 7.0.276.38 #24271

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 7.0.276.38 #24271

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 9, 2018

Refs: v8/v8@7.0.276.36...7.0.276.38

@nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Nov 9, 2018
@targos
Copy link
Member Author

targos commented Nov 9, 2018

Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp.

Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@targos
Copy link
Member Author

targos commented Nov 11, 2018

@targos
Copy link
Member Author

targos commented Nov 11, 2018

Landed in f0f1a28

@targos targos closed this Nov 11, 2018
@targos targos deleted the v8-38 branch November 11, 2018 19:19
targos added a commit that referenced this pull request Nov 11, 2018
Refs: v8/v8@7.0.276.36...7.0.276.38

PR-URL: #24271
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
Refs: v8/v8@7.0.276.36...7.0.276.38

PR-URL: #24271
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Refs: v8/v8@7.0.276.36...7.0.276.38

PR-URL: nodejs#24271
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants