tls,net: fix shutdown issue more cleanly #24290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`'drain'` event handlers may not be invoked if the stream is currently finishing. Instead, use the fact that we know when writes are active or not, and invoke the delayed shutdown handler from our own after-write callback.
Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed.
This reverts commit ac1f56c. Refs: nodejs#24288 Refs: nodejs#24075
nodejs-github-bot
added
net
|
CI: https://ci.nodejs.org/job/node-test-pull-request/18512/ I’d love a review from @oyyd on this? :) |
jasnell
approved these changes
Nov 10, 2018
oyyd
reviewed
Nov 11, 2018
|
Left a comment but LGTM 👍 |
danbev
approved these changes
Nov 16, 2018
Trott
added
the
author ready
|
Landed in 62d053b...8cdb92f |
addaleax
added a commit
that referenced
this pull request
Nov 16, 2018
`'drain'` event handlers may not be invoked if the stream is currently finishing. Instead, use the fact that we know when writes are active or not, and invoke the delayed shutdown handler from our own after-write callback. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
addaleax
added a commit
that referenced
this pull request
Nov 16, 2018
Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
addaleax
added a commit
that referenced
this pull request
Nov 16, 2018
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
`'drain'` event handlers may not be invoked if the stream is currently finishing. Instead, use the fact that we know when writes are active or not, and invoke the delayed shutdown handler from our own after-write callback. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
`'drain'` event handlers may not be invoked if the stream is currently finishing. Instead, use the fact that we know when writes are active or not, and invoke the delayed shutdown handler from our own after-write callback. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
This was referenced Dec 8, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
`'drain'` event handlers may not be invoked if the stream is currently finishing. Instead, use the fact that we know when writes are active or not, and invoke the delayed shutdown handler from our own after-write callback. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
`'drain'` event handlers may not be invoked if the stream is currently finishing. Instead, use the fact that we know when writes are active or not, and invoke the delayed shutdown handler from our own after-write callback. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'drain'event handlers may not be invoked if the streamis currently finishing. Instead, use the fact that we know
when writes are active or not, and invoke the delayed shutdown
handler from our own after-write callback.
Previously, there was no mechanism in place that would
have destroyed the TLS socket once the underlying socket
had been closed.
This reverts commit ac1f56c.
Refs: #24288
Refs: #24075
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes