deps: upgrade v8 to 3.31.74.1 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2015
|
pummel/test-vm-memleak and debugger/test-debug-break-on-uncaught are currently failing on Linux for me but that was also the case before the upgrade. |
|
Otherwise LGTM |
|
Note: We should upgrade all the LGTM. |
PR-URL: nodejs#243 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* Define and disable new flag `v8_use_external_startup_data`. * Disable v8_postmortem_support, it's broken again. Fedor (@indutny) has volunteered to fix it up in the near future. PR-URL: nodejs#243 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Assignment to a const var in strict mode is a lazy TypeError now. Update the test accordingly. PR-URL: nodejs#243 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Per the ES6 spec, V8 3.31 no longer throws a SyntaxError for scoped function declarations. PR-URL: nodejs#243 Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This was referenced Jun 28, 2021
This was referenced Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@indutny and @trevnorris
For discussion at today's TC meeting.