Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade v8 to 3.31.74.1 #243

Merged
merged 4 commits into from
Jan 7, 2015
Merged

Conversation

bnoordhuis
Copy link
Member

R=@indutny and @trevnorris

For discussion at today's TC meeting.

@bnoordhuis
Copy link
Member Author

pummel/test-vm-memleak and debugger/test-debug-break-on-uncaught are currently failing on Linux for me but that was also the case before the upgrade.

@rvagg rvagg added the tc-agenda label Jan 7, 2015
@indutny
Copy link
Member

indutny commented Jan 7, 2015

Otherwise LGTM

@trevnorris
Copy link
Contributor

Note: We should upgrade all the v8::Value::To*() and pass the Isolate. But doesn't have to be done now.

LGTM.

PR-URL: nodejs#243
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* Define and disable new flag `v8_use_external_startup_data`.

* Disable v8_postmortem_support, it's broken again.  Fedor (@indutny)
  has volunteered to fix it up in the near future.

PR-URL: nodejs#243
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Assignment to a const var in strict mode is a lazy TypeError now.
Update the test accordingly.

PR-URL: nodejs#243
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Per the ES6 spec, V8 3.31 no longer throws a SyntaxError for scoped
function declarations.

PR-URL: nodejs#243
Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis bnoordhuis merged commit 6e9d1c8 into nodejs:v1.x Jan 7, 2015
@bnoordhuis bnoordhuis deleted the upgrade-v8 branch January 7, 2015 21:14
@rvagg rvagg removed the tc-agenda label Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants