-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: make mkssldef ignore DEPRECATEDIN #24329
Conversation
/CC @nodejs/python @nodejs/build-files @nodejs/crypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment.
@@ -33,6 +33,8 @@ | |||
assert meta[2] in ('FUNCTION', 'VARIABLE') | |||
if meta[0] != 'EXIST': continue | |||
if meta[2] != 'FUNCTION': continue | |||
# In cases where meta[3] is 'DEPRECATEDIN_X_Y,CATEGORY' | |||
meta[3] = meta[3].split(',')[-1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check that the zeroth field is what you expect it to be?
if ',' in meta[3]:
fst, meta[3] = meta[3].split(',')
assert fst.startswith('DEPRECATEDIN')
The above assumes at most two fields. You could also filter out all deprecation tags:
words = meta[3].split(',')
words = [word for word in words if not word.startswith('DEPRECATEDIN')]
assert len(words) == 1
meta[3] = words.pop()
Maybe add the testcase from #20369? |
Since this didn't land, I've opened an alternative PR which adds the deprecated categories to the list of categories to export (rather than trying to ignore them): #25991. |
Make
mkssldef
ignore deprecation. e.g.TLSv1_2_*
that were deprecated in openSSL_1_1:node/deps/openssl/openssl/util/libssl.num
Line 157 in 49b0f7f
Fixes: #20369
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes