Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change anonymous closure function to arrow function #24433

Closed
wants to merge 1 commit into from
Closed

test: change anonymous closure function to arrow function #24433

wants to merge 1 commit into from

Conversation

nethraravindran
Copy link
Contributor

@nethraravindran nethraravindran commented Nov 17, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@richardlau
Copy link
Member

This appears to make the test fail:

https://travis-ci.com/nodejs/node/jobs/159275096#L9045-L9062

=== release test-net-connect-options-port ===
Path: parallel/test-net-connect-options-port
/home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js:87
    const port = this.address().port;
                      ^
TypeError: this.address is not a function
    at Server.server.listen.common.mustCall (/home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js:87:23)
    at Server.<anonymous> (/home/travis/build/nodejs/node/test/common/index.js:346:15)
    at Object.onceWrapper (events.js:273:13)
    at Server.emit (events.js:182:13)
    at emitListeningNT (net.js:1320:10)
    at process.internalTickCallback (internal/process/next_tick.js:72:19)
Command: out/Release/node /home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js
[06:06|% 100|+ 2430|-   1]: Done

@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Nov 18, 2018
trivikr
trivikr previously requested changes Nov 19, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly mentioning Request changes

test/parallel/test-net-connect-options-port.js Outdated Show resolved Hide resolved
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18885/

@Trott
Copy link
Member

Trott commented Nov 22, 2018

@trivikr Change was made and test passes. LGTY?

@addaleax
Copy link
Member

Landed in 9eab803

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Nov 23, 2018
pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Nov 23, 2018
@nethraravindran @addaleax
test: change anonymous closure function to arrow function
9eab803 
PR-URL: nodejs#24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Nov 24, 2018
@nethraravindran @targos
test: change anonymous closure function to arrow function
d96978c 
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@nethraravindran @rvagg
test: change anonymous closure function to arrow function
9bf2659 
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@nethraravindran @codebytere
test: change anonymous closure function to arrow function
f497e91 
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@nethraravindran @refack
test: change anonymous closure function to arrow function
f06b29d 
PR-URL: nodejs#24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@nethraravindran @codebytere
test: change anonymous closure function to arrow function
1f079e8 
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@nethraravindran @codebytere
test: change anonymous closure function to arrow function
6b3b769 
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@sagirk sagirk sagirk approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@trivikr trivikr trivikr left review comments

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.