src: elevate v8 namespaces of node_trace_events.cc #24469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
@gireeshpunathil : Please have a review. |
cjihrig
approved these changes
Nov 19, 2018
gireeshpunathil
approved these changes
Nov 19, 2018
gireeshpunathil
added
the
code-and-learn
|
@Jayasankar-m - thanks, now that this is your second (or third?) PR, shall I request you to address @cjihrig 's comment to be addressed (remove unwanted changes) and squash all commits into one? don't worry about the mistakes, it only strengthens your learning, to the spirit of the code & learn, thanks! |
|
Sure....
Thanks!!!
…On Mon, Nov 19, 2018, 08:11 Gireesh Punathil ***@***.*** wrote:
@Jayasankar-m <https://github.com/Jayasankar-m> - thanks, now that this
is your second (or third?) PR, shall I request you to address @cjihrig
<https://github.com/cjihrig> 's comment to be addressed (remove unwanted
changes) and squash all commits into one? don't worry about the mistakes,
it only strengthens your learning, to the spirit of the code & learn,
thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24469 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARtfThVIPOJPe0C1Yi3K6ZCETNz5_JXKks5uwhppgaJpZM4YoPtr>
.
|
jasnell
approved these changes
Nov 19, 2018
@gireeshpunathil - Have removed the unwanted changes... Regarding squashing it seems my forked copy had some other changes..need to figure out.. |
|
@Jayasankar-m - thanks, looks great now! leave the squashing part then, one of us will do it while landing. |
|
Thanks!!!
…On Mon, Nov 19, 2018, 14:37 Gireesh Punathil ***@***.*** wrote:
@Jayasankar-m <https://github.com/Jayasankar-m> - thanks, looks great
now! leave the squashing part then, one of us will do it while landing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24469 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARtfTgnraYySO_DLoK1e6VhxSPoTmIHbks5uwnTKgaJpZM4YoPtr>
.
|
thefourtheye
approved these changes
Nov 20, 2018
|
landed as 15c2491 , thanks! |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 20, 2018
PR-URL: #24469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Nov 20, 2018
PR-URL: #24469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 11, 2019
PR-URL: #24469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes