Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.0 changelog update #2448

Closed

Conversation

Fishrock123
Copy link
Contributor

So... we've encountered something that was overlooked. With the new setup, we'll have changelog divergence if we don't cherry-pick changelog commits back into master.

cc @nodejs/tsc @nodejs/release

Fishrock123 and others added 3 commits August 19, 2015 18:01
Notable changes:

* buffer: Fixed a couple large memory leaks (Ben Noordhuis)
nodejs#2352.
* crypto:
  - Fixed a couple of minor memory leaks (Karl Skomski)
nodejs#2375.
  - Signing now checks for OpenSSL errors (P.S.V.R)
nodejs#2342. **Note that this may expose
previously hidden errors in user code.**
* intl: Intl using small-icu is now enabled by default in builds
(Steven R. Loomis) nodejs#2264.
  - `String#normalize()` can now be used for unicode
normalization.
  - The `Intl` object and various `String` and `Number` methods are
present, but only support the English locale.
  - For support of all locales, node must be built with full-icu.
* tls: Fixed tls throughput being much lower after an incorrect merge
(Fedor Indutny) nodejs#2381.
* tools: The v8 tick processor now comes bundled with node (Matt
Loring) nodejs#2090.
  - This can be used by producing performance profiling output by
running node with `--perf`, then running your appropriate platform's
script on the output as found in
https://github.com/nodejs/node/tree/master/tools/v8-prof.
* util: `util.inspect(obj)` now prints the constructor name of the
object if there is one (Christopher Monsanto)
nodejs#1935.

PR-URL: nodejs#2347

Conflicts:
	src/node_version.h
Conflicts:
	src/node_version.h
@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Aug 19, 2015
@rvagg
Copy link
Member

rvagg commented Aug 20, 2015

Perhaps we should consider leaving out the src/node_version.h stuff completely and just make this a CHANGELOG update? I'd be OK with having the actual release commit live alone on the v3.x branch and having a new commit that just says something like "doc: add io.js v3.1.0 CHANGELOG"

Also, we're going to need to merge in the 0.10 and 0.12 changelogs soon .. similar issue

@trevnorris
Copy link
Contributor

Don't know if I'd have the "possibly more Buffer leaks". That isn't a known issue, it's a possible issue. One that has thus far been shown to be resolved.

@silverwind
Copy link
Contributor

LGTM, let's update this on master asap!

@silverwind
Copy link
Contributor

Also, agree with @trevnorris, we don't have any indicators for more leaks at the moment (#2308 (comment)).

@Fishrock123
Copy link
Contributor Author

Ok I'll also PR an edit. (It was just me being conservative.)

@ChALkeR
Copy link
Member

ChALkeR commented Aug 23, 2015

This should also close #2502.

@silverwind
Copy link
Contributor

@Fishrock123 ping

@ronkorving
Copy link
Contributor

The changelog on https://iojs.org/en/index.html still points to 3.0.0. Please get this out the door.

@silverwind
Copy link
Contributor

I'll do the suggested fix and land this now, given the urgency.

@thefourtheye
Copy link
Contributor

Given that #2513 has been landed, can we close this?

@rvagg
Copy link
Member

rvagg commented Aug 24, 2015

yes, I think I'm more +1 on the #2513 approach than this although the commit message could have been more informative @silverwind (sorry I didn't pick that up)

@rvagg rvagg closed this Aug 24, 2015
@thefourtheye
Copy link
Contributor

@rvagg When I landed it, cded6e7, I tried to include a few words about it. Does it look okay?

@rvagg
Copy link
Member

rvagg commented Aug 24, 2015

yeah, np @thefourtheye, it's just that in the changelog this commit is not going to be very descriptive, but that's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants