-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.1.0 changelog update #2448
v3.1.0 changelog update #2448
Conversation
Notable changes: * buffer: Fixed a couple large memory leaks (Ben Noordhuis) nodejs#2352. * crypto: - Fixed a couple of minor memory leaks (Karl Skomski) nodejs#2375. - Signing now checks for OpenSSL errors (P.S.V.R) nodejs#2342. **Note that this may expose previously hidden errors in user code.** * intl: Intl using small-icu is now enabled by default in builds (Steven R. Loomis) nodejs#2264. - `String#normalize()` can now be used for unicode normalization. - The `Intl` object and various `String` and `Number` methods are present, but only support the English locale. - For support of all locales, node must be built with full-icu. * tls: Fixed tls throughput being much lower after an incorrect merge (Fedor Indutny) nodejs#2381. * tools: The v8 tick processor now comes bundled with node (Matt Loring) nodejs#2090. - This can be used by producing performance profiling output by running node with `--perf`, then running your appropriate platform's script on the output as found in https://github.com/nodejs/node/tree/master/tools/v8-prof. * util: `util.inspect(obj)` now prints the constructor name of the object if there is one (Christopher Monsanto) nodejs#1935. PR-URL: nodejs#2347 Conflicts: src/node_version.h
PR-URL: nodejs#2347
Conflicts: src/node_version.h
Perhaps we should consider leaving out the src/node_version.h stuff completely and just make this a CHANGELOG update? I'd be OK with having the actual release commit live alone on the v3.x branch and having a new commit that just says something like "doc: add io.js v3.1.0 CHANGELOG" Also, we're going to need to merge in the 0.10 and 0.12 changelogs soon .. similar issue |
Don't know if I'd have the "possibly more Buffer leaks". That isn't a known issue, it's a possible issue. One that has thus far been shown to be resolved. |
LGTM, let's update this on master asap! |
Also, agree with @trevnorris, we don't have any indicators for more leaks at the moment (#2308 (comment)). |
Ok I'll also PR an edit. (It was just me being conservative.) |
This should also close #2502. |
@Fishrock123 ping |
The changelog on https://iojs.org/en/index.html still points to 3.0.0. Please get this out the door. |
I'll do the suggested fix and land this now, given the urgency. |
Given that #2513 has been landed, can we close this? |
yes, I think I'm more +1 on the #2513 approach than this although the commit message could have been more informative @silverwind (sorry I didn't pick that up) |
yeah, np @thefourtheye, it's just that in the changelog this commit is not going to be very descriptive, but that's ok |
So... we've encountered something that was overlooked. With the new setup, we'll have changelog divergence if we don't cherry-pick changelog commits back into
master
.cc @nodejs/tsc @nodejs/release