Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-child-process-env to use arrow functions #24482

Closed
wants to merge 3 commits into from
Closed

test: refactor test-child-process-env to use arrow functions #24482

wants to merge 3 commits into from

Commits on Nov 21, 2018

  1. test: refactor test-child-process-env to use arrow functions 

    In `test/parallel/test-child-process-env.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.
    @sagirk
    sagirk committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    0767eba View commit details
    Browse the repository at this point in the history

  2. test: wrap functions containing assertions inside a common.mustCall

    @sagirk
    sagirk committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    91fa0e1 View commit details
    Browse the repository at this point in the history

  3. Revert "test: wrap functions containing assertions inside a `common.m… 

    …ustCall`"

This reverts commit 91fa0e1.
    @sagirk
    sagirk committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    dc4bdab View commit details
    Browse the repository at this point in the history