Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the inadvertent ABI-incompatible change in #21269. The first commit reverts the ABI breaking part of d868eb7. Unfortunately doing so
willmay reintroduce a memory bug (#21021). This is where the second commit adds back the functionality in an ABI-safe way and then uses it from within core.Native modules that use
AdjustAmountOfExternalAllocatedMemory
may still miss theCheckMemoryPressure
path. This is unfortunate, but there is no easy way to do so in an ABI compatible way. Going forward, it would be good if V8 was to avoid implementation in thev8.h
file as that can lead to ABI issues like this where we can't fix the memory issue in an ABI compatible way. Such modules can use the 8.x specificAdjustAmountOfExternalAllocatedMemoryCustom
, but would require a recompilation.make -j4 test
(UNIX), orvcbuild test
(Windows) passesCI: https://ci.nodejs.org/job/node-test-pull-request/18778/
V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1887/