Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:favor arrow function in callback #24542

Closed
wants to merge 2 commits into from
Closed

test:favor arrow function in callback #24542

wants to merge 2 commits into from

Conversation

kotAPI
Copy link
Contributor

@kotAPI kotAPI commented Nov 21, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 21, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 21, 2018
@@ -23,7 +23,7 @@
const common = require('../common');
const zlib = require('zlib');

zlib.gzip('hello', common.mustCall(function(err, out) {
zlib.gzip('hello', common.mustCall((err, out)=> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: space is required before arrow to pass the lint test
https://travis-ci.com/nodejs/node/jobs/159977196

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that, I've pushed again with the required changes, thanks!

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once it passes linting.

@Trott
Copy link
Member

Trott commented Nov 21, 2018

@kotAPI
Copy link
Contributor Author

kotAPI commented Nov 21, 2018

@Trott @cjihrig @sreepurnajasti any tips on how to make the remaining tests pass?

@cjihrig
Copy link
Contributor

cjihrig commented Nov 21, 2018

It should just be a matter of running it again.

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18856/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2018
@kotAPI
Copy link
Contributor Author

kotAPI commented Nov 22, 2018

Ahh, thanks @cjihrig :D

@gireeshpunathil
Copy link
Member

fast-track? please 👍

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 22, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 22, 2018
PR-URL: nodejs#24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott
Copy link
Member

Trott commented Nov 22, 2018

Landed in 21522cb.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 22, 2018
targos pushed a commit that referenced this pull request Nov 24, 2018
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
codebytere pushed a commit that referenced this pull request Jan 13, 2019
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants