Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: elevate v8 namespaces for node_process.cc #24578

Closed
wants to merge 1 commit into from

Conversation

Jayasankar-m
Copy link
Contributor

elevate namespace for repeated entities.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 23, 2018
@Jayasankar-m
Copy link
Contributor Author

@gireeshpunathil : Pls review

@danbev
Copy link
Contributor

danbev commented Nov 28, 2018

@Jayasankar-m Would you be able to rebase this PR and resolve the conflict in node_process.cc?

@Jayasankar-m
Copy link
Contributor Author

Jayasankar-m commented Nov 28, 2018

@Jayasankar-m Would you be able to rebase this PR and resolve the conflict in node_process.cc?

@danbev : Done!! Please review.

@Jayasankar-m Jayasankar-m force-pushed the v8nodeprocess branch 2 times, most recently from 292bc83 to ca0076a Compare November 28, 2018 15:16
elevate namespace for repeated entities.
resolved conflicts.
@danbev
Copy link
Contributor

danbev commented Nov 29, 2018

@danbev
Copy link
Contributor

danbev commented Nov 29, 2018

Re-run failing node-test-commit-freebsd

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Dec 1, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-commit/23835/ ✔️

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 1, 2018
Elevate namespace for repeated entities.
Resolved conflicts.

PR-URL: nodejs#24578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 1, 2018

Landed in bbb9d37

@Trott Trott closed this Dec 1, 2018
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
Elevate namespace for repeated entities.
Resolved conflicts.

PR-URL: #24578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Elevate namespace for repeated entities.
Resolved conflicts.

PR-URL: nodejs#24578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Jun 25, 2019
Elevate namespace for repeated entities.
Resolved conflicts.

PR-URL: #24578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants