-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fixed the arguments order in assert.strictEqual
#24607
Conversation
fast-track? pls 👍 |
only failure in windows-fanned |
landed as f351c5d , thanks! |
PR-URL: #24607 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Per the Collaborators Guide, we may not land without a green or yellow CI. Please don't disregard failures, including known failures. (If they are to be disregarded, they need to be marked in the status file, which will result in a yellow CI when they fail.) Thanks. |
@Trott - thanks for the correction! I did not know that we should not land even when the failing test has an open issue on it. I will follow that route. the relevant section in the guide, however is not explicit on it and assumes that the failing job is flaky and may recover from a
|
PR-URL: #24607 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
I believe Resume Build now works in all cases including the fanned jobs. (If it doesn't, definitely notify Build WG. Or just use Rebuild instead of Resume Build. Or both.) |
PR-URL: nodejs#24607 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
PR-URL: #24607 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
PR-URL: #24607 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes