Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix the arguments order in assert.strictEqual #24620

Closed
wants to merge 1 commit into from
Closed

test: fix the arguments order in assert.strictEqual #24620

wants to merge 1 commit into from

Conversation

pastak
Copy link
Contributor

@pastak pastak commented Nov 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18951/

@gireeshpunathil
Copy link
Member

fast-track? pls 👍

@shisama
Copy link
Contributor

shisama commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19003/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19016/

@gireeshpunathil
Copy link
Member

single failure in arm-fanned is:

22:29:48 not ok 311 known_issues/test-vm-timeout-escape-nexttick
22:29:48   ---
22:29:48   duration_ms: 2.80
22:29:48   severity: fail
22:29:48   stack: |-
22:29:48   ...

@gireeshpunathil
Copy link
Member

@Trott - should I get this test under ./test/known_issues/known_issues.status through a PR? pls let me know.

@gireeshpunathil gireeshpunathil mentioned this pull request Nov 29, 2018
Closed
4 tasks
@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19023/

@Trott
Copy link
Member

Trott commented Nov 29, 2018 •
edited
Loading

@Trott - should I get this test under ./test/known_issues/known_issues.status through a PR? pls let me know.

Probably a good idea if we've seen it more than once (which we have). I mean, unless there's an obvious fix (which there probably isn't).

Errr...that was a long-winded way of saying, "Yes, sounds like a good idea to me."

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19026/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19034/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
@gireeshpunathil @Trott
test: mark test-vm-timeout-escape-nexttick flaky
9e33e86 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: nodejs#24712
Refs: nodejs#24620
Refs: nodejs#24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19047/

@Trott
Copy link
Member

Trott commented Nov 29, 2018 •
edited
Loading

Now that the super-problematic test is marked as flaky, let's do a re-run from scratch (so that we get that flaky status marking in the CI for this) and hopefully this passes no problem: https://ci.nodejs.org/job/node-test-pull-request/19055/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Landed in 97fedef.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 29, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
@pastak @Trott
test: fix the arguments order in assert.strictEqual
97fedef 
PR-URL: nodejs#24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
targos pushed a commit that referenced this pull request Nov 29, 2018
@gireeshpunathil @targos
test: mark test-vm-timeout-escape-nexttick flaky
1035e36 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Nov 29, 2018
@pastak @targos
test: fix the arguments order in assert.strictEqual
d5bf736 
PR-URL: #24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@gireeshpunathil @refack
test: mark test-vm-timeout-escape-nexttick flaky
a4a6b68 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: nodejs#24712
Refs: nodejs#24620
Refs: nodejs#24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@pastak @refack
test: fix the arguments order in assert.strictEqual
6d3d33e 
PR-URL: nodejs#24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@gireeshpunathil @BethGriggs
test: mark test-vm-timeout-escape-nexttick flaky
e89f5e5 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@pastak @BethGriggs
test: fix the arguments order in assert.strictEqual
af58209 
PR-URL: #24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gireeshpunathil @rvagg
test: mark test-vm-timeout-escape-nexttick flaky
28aca77 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@pastak @rvagg
test: fix the arguments order in assert.strictEqual
eecb2a4 
PR-URL: #24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shisama shisama shisama approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Leko Leko Leko approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@pastak @gireeshpunathil @shisama @Trott @addaleax @Leko @lpinca @cjihrig @joyeecheung @nodejs-github-bot