Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the arguments order in assert.strictEqual #24624

Closed
wants to merge 1 commit into from

Conversation

sigwyg
Copy link

@sigwyg sigwyg commented Nov 24, 2018

I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2018
@hiroppy hiroppy added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

@gireeshpunathil
Copy link
Member

fast-track? pls 👍

@Trott
Copy link
Member

Trott commented Nov 29, 2018

@gireeshpunathil
Copy link
Member

arm-fanned has 3 failures:

2 of type:

23:19:02 not ok 311 known_issues/test-vm-timeout-escape-nexttick
23:19:02   ---
23:19:02   duration_ms: 7.354
23:19:02   severity: fail
23:19:02   stack: |-
23:19:02   ...

and one of:

22:27:30 not ok 28 parallel/test-async-hooks-http-parser-destroy
22:27:30   ---
22:27:30   duration_ms: 10.274
22:27:30   severity: fail
22:27:30   exitcode: 1
22:27:30   stack: |-
22:27:30     assert.js:351
22:27:30         throw err;
22:27:30         ^
22:27:30     
22:27:30     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
22:27:30     
22:27:30       assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
22:27:30     
22:27:30         at createdIds.forEach (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16)
22:27:30         at Array.forEach (<anonymous>)
22:27:30         at Timeout.setTimeout [as _onTimeout] (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
22:27:30         at listOnTimeout (timers.js:324:15)
22:27:30         at processTimers (timers.js:268:5)
22:27:30   ...

@Trott
Copy link
Member

Trott commented Nov 29, 2018

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Landed in d12d023.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 29, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431

PR-URL: nodejs#24624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@sigwyg sigwyg deleted the sigwyg/fixed-assert-strictEqual branch November 29, 2018 10:13
targos pushed a commit that referenced this pull request Nov 29, 2018
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

PR-URL: #24624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431

PR-URL: nodejs#24624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

PR-URL: #24624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

PR-URL: #24624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.