Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: elevate v8 namespaces referenced #24657

Closed
wants to merge 2 commits into from
Closed

src: elevate v8 namespaces referenced #24657

wants to merge 2 commits into from

Conversation

juanarbol
Copy link
Member

I saw non elevated v8 namespaces, and v8::HandleScope already elevated but invocated as v8::HandleScope not just HandleScope

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 26, 2018
refack
refack reviewed Nov 26, 2018
View reviewed changes
src/async_wrap.cc Outdated
@@ -374,7 +381,7 @@ static void RegisterDestroyHook(const FunctionCallbackInfo<Value>& args) {
p->target.Reset(isolate, args[0].As<Object>());
p->propBag.Reset(isolate, args[2].As<Object>());
p->target.SetWeak(
p, AsyncWrap::WeakCallback, v8::WeakCallbackType::kParameter);
p, AsyncWrap::WeakCallback, WeakCallbackType::kParameter);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can now unwrap this into a single line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what is the max width of line? Linter could break this, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max length is 80 and if you exceed that the linter will pick it up. You can run make lint-cpp to check any changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and wrapped!

@danbev
Copy link
Contributor

danbev commented Nov 28, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18995/

@juanarbol
Copy link
Member Author

@rvagg 🤦‍♂️ My bad, at this hour I still thinking why I rebase, what a mess...

@Trott
Copy link
Member

Trott commented Nov 29, 2018

@juanarbol I checked out your branch and ran git fetch upstream && git rebase upstream/master. The result looked good and I force-pushed it to your branch. So this PR should be back in shape. Can you double-check that it looks good to you and maybe we can get one or two reviewers to confirm their approval? Meanwhile, I'll run CI. If all those things check out, we can land this.

@Trott
Copy link
Member

Trott commented Nov 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19033/

@juanarbol
Copy link
Member Author

@Trott I think it's ok! Thank you!!!

@Trott
Copy link
Member

Trott commented Nov 30, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19077/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2018
@Trott
Copy link
Member

Trott commented Nov 30, 2018

Optimistic Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19091/

@Trott
Copy link
Member

Trott commented Dec 1, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19105/

@Trott
Copy link
Member

Trott commented Dec 1, 2018

Landed in d4273c4

@Trott Trott closed this Dec 1, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 1, 2018
@juanarbol @Trott
src: elevate v8 namespaces referenced
d4273c4 
PR-URL: nodejs#24657
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@juanarbol @BridgeAR
src: elevate v8 namespaces referenced
0148c1d 
PR-URL: #24657
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@juanarbol @refack
src: elevate v8 namespaces referenced
55cfcee 
PR-URL: nodejs#24657
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@juanarbol @BethGriggs
src: elevate v8 namespaces referenced
4444cdb 
PR-URL: #24657
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@juanarbol @rvagg
src: elevate v8 namespaces referenced
ed0ced3 
PR-URL: #24657
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@juanarbol juanarbol deleted the src-v8-namespaces branch January 19, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack left review comments

@danbev danbev danbev left review comments

@fhinkel fhinkel fhinkel approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JungMinu JungMinu JungMinu approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@itskumaradarsh itskumaradarsh itskumaradarsh approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.