Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x backport] doc: sort bottom-of-file markdown links #24680

Closed
wants to merge 1 commit into from
Closed

[v11.x backport] doc: sort bottom-of-file markdown links #24680

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Backport of #24679

Preemptive, the sorting doesn't cherrypick well down to release branches, this should help prevent annoying conflicts in the docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v11.x labels Nov 27, 2018
@sam-github sam-github mentioned this pull request Nov 27, 2018
Closed
4 tasks
@vsemozhetbyt
Copy link
Contributor

Does this need rebasing?

@sam-github
Copy link
Contributor Author

rebased

vsemozhetbyt
vsemozhetbyt reviewed Nov 28, 2018
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
vsemozhetbyt
vsemozhetbyt approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a nit.

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@sam-github
Copy link
Contributor Author

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1729/

@targos
Copy link
Member

targos commented Nov 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1732/

@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1755/

@sam-github
doc: sort bottom-of-file markdown links
476272a 
Backport-PR-URL: nodejs#24680
PR-URL: nodejs#24679
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@sam-github
Copy link
Contributor Author

I force pushed with amended description, no other changes. Mostly to get Travis to re-build it.

@sam-github
Copy link
Contributor Author

@BridgeAR @targos you may want to land this on v11.x-staging soon to help prevent conflicts from PRs touching docs after 64cea5a on master.

@BridgeAR
Copy link
Member

BridgeAR commented Dec 3, 2018

@sam-github thanks. I am going to prepare a new release tomorrow.

@sam-github
Copy link
Contributor Author

travis can never find the head commit, AFAICT, it always fails.

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1816/

@BridgeAR
Copy link
Member

BridgeAR commented Dec 5, 2018

Landed in 66d8330

@BridgeAR BridgeAR closed this Dec 5, 2018
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@sam-github @BridgeAR
doc: sort bottom-of-file markdown links
66d8330 
Backport-PR-URL: #24680
PR-URL: #24679
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sam-github @nodejs-github-bot @vsemozhetbyt @targos @BridgeAR @Trott