Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: describe current HTTP header size limit #24700

Closed
wants to merge 2 commits into from
Closed

doc: describe current HTTP header size limit #24700

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1708/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Nov 28, 2018
@sam-github
Copy link
Contributor Author

This does not replace #24693, it fixes the existing reference to 80KB in errors.md, but doesn't touch the HTTP docs themselves. It was intended that this be part of 1860352 but it got missed, sorry.

mcollina
mcollina approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
doc: describe current HTTP header size limit
19cdee8 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693
vsemozhetbyt
vsemozhetbyt reviewed Nov 28, 2018
View reviewed changes
doc/api/errors.md Outdated Show resolved Hide resolved
@vsemozhetbyt vsemozhetbyt added http Issues or PRs related to the http subsystem. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. labels Nov 28, 2018
@vsemozhetbyt @sam-github
fixup
bb3d672 
Co-Authored-By: sam-github <vieuxtech@gmail.com>
@sam-github
Copy link
Contributor Author

sorry, misunderstood format of description field

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1711/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2018
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 28, 2018
@Trott
Copy link
Member

Trott commented Nov 28, 2018

Landed in 063e8fb

@Trott Trott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@sam-github @Trott
doc: describe current HTTP header size limit
063e8fb 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693

PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@sam-github sam-github deleted the doc-8kb-http-header-limit branch November 28, 2018 21:59
targos pushed a commit that referenced this pull request Nov 29, 2018
@sam-github @targos
doc: describe current HTTP header size limit
68dc100 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@sam-github @MylesBorins
doc: describe current HTTP header size limit
f30d169 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@sam-github @MylesBorins
doc: describe current HTTP header size limit
e669733 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
This was referenced Dec 26, 2018
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@sam-github @refack
doc: describe current HTTP header size limit
f045f1b 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693

PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. fast-track PRs that do not need to wait for 48 hours to land. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing API docs for recent changes in HTTP module
6 participants
@sam-github @nodejs-github-bot @vsemozhetbyt @Trott @mcollina @MylesBorins