Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: show stdout and stderr in test-cli-syntax when it fails #24720

Closed
wants to merge 1 commit into from
Closed

test: show stdout and stderr in test-cli-syntax when it fails #24720

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

To help debugging the flake with the log from the CI.

Refs: #24403

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@joyeecheung
test: show stdout and stderr in test-cli-syntax when it fails
45abbe4 
To help debugging the flake with the log from the CI.
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1723/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 29, 2018
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19043/
Stress Test: https://ci.nodejs.org/job/node-stress-single-test/2116/

@joyeecheung
Copy link
Member Author

There seems to be something off with another test case: err.code is not always set when the process fails, somehow we got a null instead of a number https://ci.nodejs.org/job/node-stress-single-test/2116/nodes=freebsd11-x64/testReport/junit/(root)/test121/parallel_test_cli_syntax/

@joyeecheung
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19067/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build won't rebase so you'll get a lot of that irksome known_issues/test-vm-timeout-escape-nexttick on Raspberry Pi. Here's a rebuild for Raspberry Pi only so that it rebases and gets the status file change marking that test as flaky: https://ci.nodejs.org/job/node-test-commit-arm-fanned/4761/

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 1, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 1, 2018
@joyeecheung @Trott
test: show stdout and stderr in test-cli-syntax when it fails
3fb627b 
To help debugging the flake with the log from the CI.

PR-URL: nodejs#24720
Refs: nodejs#24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 1, 2018

Landed in 3fb627b

@Trott Trott closed this Dec 1, 2018
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@joyeecheung @BridgeAR
test: show stdout and stderr in test-cli-syntax when it fails
085f5b6 
To help debugging the flake with the log from the CI.

PR-URL: #24720
Refs: #24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung @refack
test: show stdout and stderr in test-cli-syntax when it fails
b298ec3 
To help debugging the flake with the log from the CI.

PR-URL: nodejs#24720
Refs: nodejs#24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@joyeecheung @BethGriggs
test: show stdout and stderr in test-cli-syntax when it fails
46e37ad 
To help debugging the flake with the log from the CI.

PR-URL: #24720
Refs: #24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@joyeecheung @rvagg
test: show stdout and stderr in test-cli-syntax when it fails
850a1af 
To help debugging the flake with the log from the CI.

PR-URL: #24720
Refs: #24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joyeecheung @nodejs-github-bot @Trott @danbev @addaleax @lpinca @richardlau @BethGriggs