test: check invalid argument error for option #24736
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a test for the validateArguments function in TextDecoder
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAs another note I would like to test the function
makeTextDecoderJS
in encoding.js but I do not know how to force hasIntl to be false without rebuilding node with the option--without-intl
. Is there a way to do this at runtime? (Maybe it could be providing a icu-data-dir that has it disabled? I just don't know what that file would look like if that is the case)If anyone knows a way to set hasIntl to off let me know because I can just include those tests and get the coverage of encoding.js up even more!