Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert,util: fix comparison #24749

Closed
wants to merge 3 commits into from
Closed

assert,util: fix comparison #24749

wants to merge 3 commits into from

Commits on Nov 30, 2018

  1. assert: fix loose deepEqual map comparison 

    Loose map comparison had an logic error. It will now be properly
compared.
    @BridgeAR
    BridgeAR committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    2a21991 View commit details
    Browse the repository at this point in the history

  2. assert,util: fix sparse array comparison 

    Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.
    @BridgeAR
    BridgeAR committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    02c2bd7 View commit details
    Browse the repository at this point in the history

  3. test: improve comparison coverage to 100%

    @BridgeAR
    BridgeAR committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    d851e08 View commit details
    Browse the repository at this point in the history