Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix eslint usage for Node.js 8 and before #24753

Closed
wants to merge 2 commits into from
Closed

tools: fix eslint usage for Node.js 8 and before #24753

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be51768
tools: fix eslint usage for Node.js 8 and before
BridgeAR Nov 30, 2018
540226b
fixup: capitalize ESLint
vsemozhetbyt Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ Module._findPath = (request, paths, isMain) => {
if (!r && hacks.includes(request)) {
try {
return require.resolve(`./tools/node_modules/${request}`);
} catch {
// Keep the variable in place to ensure that eslint started by older Node.js
BridgeAR marked this conversation as resolved.
Show resolved Hide resolved
// versions work as expected.
// eslint-disable-next-line no-unused-vars
} catch (e) {
return require.resolve(
`./tools/node_modules/eslint/node_modules/${request}`);
}
Expand Down