-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: use NativeModuleLoader to compile all the bootstrappers #24775
Conversation
cc @addaleax @jasnell @devsnek Since the top-level indentation in the two bootstrappers are now eliminated, this patch would be easier to review with https://github.com/nodejs/node/pull/24775/files?w=1 (with the whitespace-only changes stripped) |
This patch moves all the bootstrapper compilation to use NativeModuleLoader::CompileAndCall(). With this we no longer need to mess with the error decoration and handling any more - there is no point in handling the JS error occurred during bootstrapping by ourselves, we should just crash or let the VM handle it.
5a0f201
to
47fd257
Compare
Landed in edcb950, thanks! |
This patch moves all the bootstrapper compilation to use NativeModuleLoader::CompileAndCall(). With this we no longer need to mess with the error decoration and handling any more - there is no point in handling the JS error occurred during bootstrapping by ourselves, we should just crash or let the VM handle it. PR-URL: #24775 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This does not land cleanly on v11.x (it seems like it relies on the console changes which did not land cleanly and it is likely that they apply fine as soon as they got backported). Please open a backport or change the label accordingly. |
This does not land cleanly or near cleanly even after applying the recent console commits :/. @joyeecheung could you please have another look? There are a couple of PRs from you which still need backports but I do not know which is the first one to backport and if there's maybe a semver-major PR which should be backported without breaking changes similar to the console one. |
@BridgeAR I think this does not apply cleanly mostly because there are out-of-order commits backported to v11.x-staging before this one is backported. I'll try reverting those first before doing a clean backport |
This could land cleanlier on v11.x-staging after
e97acf7 lib: expose all type checks from the internal types module
There will still be a small conflict in |
This patch moves all the bootstrapper compilation to use NativeModuleLoader::CompileAndCall(). With this we no longer need to mess with the error decoration and handling any more - there is no point in handling the JS error occurred during bootstrapping by ourselves, we should just crash or let the VM handle it. PR-URL: nodejs#24775 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This patch moves all the bootstrapper compilation to use NativeModuleLoader::CompileAndCall(). With this we no longer need to mess with the error decoration and handling any more - there is no point in handling the JS error occurred during bootstrapping by ourselves, we should just crash or let the VM handle it. PR-URL: #24775 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: #25446
This patch moves all the bootstrapper compilation to use NativeModuleLoader::CompileAndCall(). With this we no longer need to mess with the error decoration and handling any more - there is no point in handling the JS error occurred during bootstrapping by ourselves, we should just crash or let the VM handle it. PR-URL: nodejs#24775 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This patch moves all the bootstrapper compilation to use NativeModuleLoader::CompileAndCall(). With this we no longer need to mess with the error decoration and handling any more - there is no point in handling the JS error occurred during bootstrapping by ourselves, we should just crash or let the VM handle it. PR-URL: nodejs#24775 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: nodejs#25446
This patch moves all the bootstrapper compilation to use
NativeModuleLoader::CompileAndCall(). With this we no longer
need to mess with the error decoration and handling any more -
there is no point in handling the JS error occurred during bootstrapping
by ourselves, we should just crash or let the VM handle it.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes