Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add authority and scheme psuedo headers #24777

Closed
wants to merge 3 commits into from
Closed

doc: add authority and scheme psuedo headers #24777

wants to merge 3 commits into from

Conversation

kenigbolo
Copy link
Contributor

doc: add authority and scheme psuedo headers to http2.md

This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

Fixes: #23825

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]

@kenigbolo
doc: add authority and scheme psuedo headers
9de56b9 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

Fixes: nodejs#23825
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Dec 2, 2018
Trott
Trott reviewed Dec 2, 2018
View reviewed changes
doc/api/http2.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Dec 2, 2018
View reviewed changes
doc/api/http2.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Dec 2, 2018

@nodejs/http2

vsemozhetbyt
vsemozhetbyt reviewed Dec 2, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just some nits.

doc/api/http2.md Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
@kenigbolo
Copy link
Contributor Author

@vsemozhetbyt Thanks. Made the adjustments accordingly

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1827/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in bb01597
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Dec 5, 2018
@kenigbolo @vsemozhetbyt
doc: add authority and scheme psuedo headers
bb01597 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 6, 2018
@kenigbolo @BridgeAR
doc: add authority and scheme psuedo headers
ec533ac 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
Merged
4 tasks
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@kenigbolo @BridgeAR
doc: add authority and scheme psuedo headers
71e520c 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@kenigbolo @BridgeAR
doc: add authority and scheme psuedo headers
b127a48 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@kenigbolo @refack
doc: add authority and scheme psuedo headers
98f5821 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: nodejs#24777
Fixes: nodejs#23825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@kenigbolo @BethGriggs
doc: add authority and scheme psuedo headers
2b03878 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@kenigbolo @BethGriggs
doc: add authority and scheme psuedo headers
ff26cfb 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@kenigbolo @rvagg
doc: add authority and scheme psuedo headers
d0a0bbd 
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@Trott Trott Trott left review comments

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for Http2ServerRequest properties
6 participants
@kenigbolo @Trott @vsemozhetbyt @danbev @addaleax @nodejs-github-bot