Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: specialize building and storage of process.config #24816

Closed
wants to merge 1 commit into from
Closed

process: specialize building and storage of process.config #24816

wants to merge 1 commit into from

Commits on Dec 6, 2018

  1. process: specialize building and storage of process.config 

    Instead of treating config.gypi as a JavaScript file, specialize
the processing in js2c and make the serialized result a real JSON
string (with 'true' and 'false' converted to boolean values) so
we don't have to use a custom deserializer during bootstrap.

In addition, store the JSON string separately in NativeModuleLoader,
and keep it separate from the map of the builtin source code, so
we don't have to put it onto `NativeModule._source` and delete it
later, though we still preserve it in `process.binding('natives')`,
which we don't use anymore.

This patch also makes the map of builtin source code and the
config.gypi string available through side-effect-free getters
in C++.
    @joyeecheung
    joyeecheung committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    42ab2d3 View commit details
    Browse the repository at this point in the history