-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: use author's titles for linked resources #24837
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Collaborator Guide links to use the title of the item being linked.
vsemozhetbyt
approved these changes
Dec 4, 2018
cjihrig
approved these changes
Dec 4, 2018
vsemozhetbyt
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 4, 2018
hiroppy
approved these changes
Dec 4, 2018
Fishrock123
approved these changes
Dec 5, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2018
Update Collaborator Guide links to use the title of the item being linked. PR-URL: nodejs#24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Landed in e9a1fee |
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
Update Collaborator Guide links to use the title of the item being linked. PR-URL: #24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
Update Collaborator Guide links to use the title of the item being linked. PR-URL: #24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
Update Collaborator Guide links to use the title of the item being linked. PR-URL: #24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Update Collaborator Guide links to use the title of the item being linked. PR-URL: nodejs#24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Update Collaborator Guide links to use the title of the item being linked. PR-URL: #24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
Update Collaborator Guide links to use the title of the item being linked. PR-URL: #24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Update Collaborator Guide links to use the title of the item being linked. PR-URL: #24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Collaborator Guide links to use the title of the item being
linked.
Collaborators, 👍 here to fast-track.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes