Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix api documentation of http.createServer #24869

Closed
wants to merge 1 commit into from
Closed

doc: fix api documentation of http.createServer #24869

wants to merge 1 commit into from

Conversation

aautio
Copy link

@aautio aautio commented Dec 6, 2018

Fixes: #24105

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. v8.x labels Dec 6, 2018
@aautio aautio mentioned this pull request Dec 6, 2018
Closed
@trivikr
Copy link
Member

trivikr commented Dec 8, 2018

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1864/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 8, 2018
@Trott
Copy link
Member

Trott commented Dec 8, 2018

This needs someone from @nodejs/releasers to land it because it is on an LTS branch. /ping @BethGriggs @rvagg @MylesBorins or anyone else who can do it. Thanks!

@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 8, 2018
MylesBorins pushed a commit that referenced this pull request Dec 10, 2018
@aautio @MylesBorins
doc: fix api documentation of http.createServer
6922231 
Fixes: #24105

PR-URL: #24869
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 6922231

This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aautio @trivikr @Trott @MylesBorins @lpinca @nodejs-github-bot