Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test-http2-session-timeout.js and move to parallel #24877

Closed
wants to merge 2 commits into from
Closed

Fix test-http2-session-timeout.js and move to parallel #24877

wants to merge 2 commits into from

Commits on Dec 6, 2018

  1. test: make http2 timeout test robust 

    Instead of using magic values for the server timeout in
test-http2-session-timeout, measure the duration of the first request
(which should be longer than subsequent requests) and use that value.

Fixes: nodejs#20628
    @Trott
    Trott committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    59bf8fa View commit details
    Browse the repository at this point in the history

  2. test: move http2 test to parallel 

    A fix to test-http2-session-timeout makes it sufficiently robust that it
can be moved to the parallel directory.
    @Trott
    Trott committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    9c93c03 View commit details
    Browse the repository at this point in the history