Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix nits in lib\internal\bootstrap\node.js #24914

Closed
wants to merge 1 commit into from
Closed

lib: fix nits in lib\internal\bootstrap\node.js #24914

wants to merge 1 commit into from

Commits on Dec 11, 2018

  1. lib: fix nits in lib\internal\bootstrap\node.js

    * Fix typos and unify differences in comments and messages.
    * Unwrap short lines.
    * Eliminate short-living variables.
    * Fix sorting in an array of strings.
    * Unify iteration over arrays of strings.
    * Reduce string concatenation.
    * Cache retrieved object/array properties.
    * Simplify conditional logic.
    * Reduce module loading calls if at least one of them isn't conditional:
      `internalBinding('config')`,
      `internalBinding('worker')`,
      `NativeModule.require('internal/util')`,
      `NativeModule.require('util')`.
    vsemozhetbyt committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    824f90b View commit details
    Browse the repository at this point in the history