-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: corrected version http.createServer options addition #25001
Conversation
0fd86f0
to
413f652
Compare
Both versions should be documented as this feature was backported from v9.x to v8.x. |
Surely the documented version is since as opposed to a list of versions? If I am to list multiple, do you suggest it lists both in the same way.
or explicitly note it was backported
Perhaps you could suggest an example of another backported feature I can reference? |
You can use comma-separated lists, like (newest versions first): - version: v9.6.0, v8.12.0 That's how we're currently handling this in other parts of the documentation. |
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() nodejs#15752
413f652
to
a891b93
Compare
@nodejs/documentation |
Landed in 9a39a65 |
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() #15752 PR-URL: #25001 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() #15752 PR-URL: #25001 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() #15752 PR-URL: #25001 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
8.12 Changelog
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0
Specifically
[01dc646] - (SEMVER-MINOR) http: add options to http.createServer() (Peter Marton) #15752
Pull
#15752
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes