src,lib: prefer internal/options over process._foo #25063
Conversation
nodejs-github-bot
added
the
c++
| @@ -104,7 +105,7 @@ function startup() { | |||
| NativeModule.require('internal/inspector_async_hook').setup(); | |||
| } | |||
|
|
|||
| const { getOptionValue } = NativeModule.require('internal/options'); | |||
| getOptionValue = NativeModule.require('internal/options').getOptionValue; | |||
There was a problem hiding this comment.
We could keep the same extraction method as before with:
({ getOptionValue } = NativeModule.require('internal/options'));There was a problem hiding this comment.
@mscdex I thought about it but thought this was maybe easier to read without the parenthesis? If you’d prefer this, I’d be totally okay with that too?
There was a problem hiding this comment.
I don't mind either way, was just throwing that out there.
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up).
addaleax
force-pushed
the
less-process-dot-something
branch
from
174cee9 to
8f105f8
Compare
There was a problem hiding this comment.
LGTM. Thanks for picking this up! I tried to take a stab at this a while back but it was more tricky than I thought to eliminate some of these from JS land (tests were failing/hanging for legit reasons which I was not able to figure out), but it's good to get rid of them incrementally 👍 And looking forward to the followup!
|
Re-run of failing node-test-commit-aix ✔️ |
|
Landed in 8b57208. |
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up). PR-URL: #25063 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This doesn't land cleanly on v11.x, should it be backported? |
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up). PR-URL: #25063 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Applies cleanly now. |
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up). PR-URL: nodejs#25063 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up). PR-URL: nodejs#25063 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This addresses a couple
TODOcomments and allows usto remove a number of underscored properties from
process(in a semver-major follow-up).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes