Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove test-related GYP files #25097

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Dec 17, 2018

  • Less files to maintain.
  • We don't use them.
  • We build with GN to run V8 tests.

Fixes: #25095
Refs: #25010

/cc @ryzokuken

- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: nodejs#25095
Refs: nodejs#25010
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Dec 17, 2018
@targos targos added the build Issues and PRs related to build files or the CI. label Dec 17, 2018
@targos
Copy link
Member Author

targos commented Dec 17, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 18, 2018
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thanks, @targos.

@targos
Copy link
Member Author

targos commented Dec 20, 2018

Landed in f0e4609

@targos targos closed this Dec 20, 2018
@targos targos deleted the v8-gyp-no-tests branch December 20, 2018 15:58
targos added a commit that referenced this pull request Dec 20, 2018
- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: #25095
Refs: #25010

PR-URL: #25097
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: nodejs#25095
Refs: nodejs#25010

PR-URL: nodejs#25097
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants